Skip to content

use the message argument of assertX functions #6118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

use the message argument of assertX functions #6118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions book/testing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,8 @@ document::
$client->getResponse()->headers->contains(
'Content-Type',
'application/json'
)
),
'"Content-Type" header is NOT "application/json"' // optional message shown on failure
);

// Assert that the response content contains a string
Expand All @@ -268,7 +269,9 @@ document::
$this->assertRegExp('/foo(bar)?/', $client->getResponse()->getContent());

// Assert that the response status code is 2xx
$this->assertTrue($client->getResponse()->isSuccessful());
$this->assertTrue($client->getResponse()->isSuccessful(),
'response status code is NOT 2xx'
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indention looks weird
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, ) should be at the same level as $this->...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be either:

$this->assertTrue( $client->getResponse()->isSuccessful(), 'Response status code is 2xx' );

Or just everything on one line.
// Assert that the response status code is 404
$this->assertTrue($client->getResponse()->isNotFound());
// Assert a specific 200 status code
Expand All @@ -279,7 +282,8 @@ document::

// Assert that the response is a redirect to /demo/contact
$this->assertTrue(
$client->getResponse()->isRedirect('/demo/contact')
$client->getResponse()->isRedirect('/demo/contact'),
'response is NOT a redirect to /demo/contact'
);
// ...or simply check that the response is a redirect to any URL
$this->assertTrue($client->getResponse()->isRedirect());
Expand Down