Updated the session proxy article

[javiereguiluz]

Q	A
Doc fix?	yes
New docs?	no
Applies to	all
Fixed tickets	#5844

I'm not sure if this is what @xabbuh was talking about in the related issue.

[javiereguiluz]

Could I get a review for these changes? Thanks!

[HeahDude]

Namespaces use backslashes \

[javiereguiluz]

😱 Nice catch! Fixed. Thanks!

[HeahDude]

I left some very minor comments but I like your changes 👍

[xabbuh]

you can simply use register()

[javiereguiluz]

I'm sorry but I don't understand this comment.

[ogizanagi]

@javiereguiluz :

- $container->setDefinition('app.session_handler', new Definition('AppBundle\Session\CustomSessionHandler')); + $container->register('app.session_handler', 'AppBundle\Session\CustomSessionHandler');

http://api.symfony.com/master/Symfony/Component/DependencyInjection/ContainerBuilder.html#method_register

[javiereguiluz]

Thanks @ogizanagi! It's fixed now.

[javiereguiluz]

I've fixed most of the issues reported by reviewers.

[xabbuh]

I think we should use a complete XML example here and below.

[xabbuh]

So it should be:

<?xml version="1.0" encoding="UTF-8" ?> <container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services  http://symfony.com/schema/dic/services/services-1.0.xsd"> <services> <service id="app.session_handler" class="AppBundle\Session\CustomSessionHandler" /> </services> </container>

[xabbuh]

@javiereguiluz Apart from the XML config examples this looks ready to me.

[javiereguiluz]

I've updated the examples to show the full XML config. Thanks!

[xabbuh]

👍

[xabbuh]

ping @weaverryan @wouterj

[wouterj]

Thanks Javier, it looks great!