Skip to content

Conversation

@andrerom
Copy link
Contributor

@andrerom andrerom commented Aug 9, 2015

Q A
Doc fix? no
New docs? yes symfony/symfony#15011
Applies to 2.8
Fixed tickets
@andrerom
Copy link
Contributor Author

andrerom commented Aug 9, 2015

Updated to reflect updated PR, review ping @wouterj, @weaverryan, @xabbuh.

_new/changed lines: 24-25, 30-35, 67-_*

@andrerom andrerom force-pushed the bundle_dependencies branch from 09fe35f to fea98af Compare August 9, 2015 18:58
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Specifying Dependencies" (title case rules are to capitialize every word, except from closed-class words)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should class be written in uppercase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class

I can add this link to the word here to make that, and the feature itself more clear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added link in 3877991

@OskarStark
Copy link
Contributor

thank you @andrerom

@andrerom andrerom force-pushed the bundle_dependencies branch 3 times, most recently from 714fb9a to 25b0351 Compare August 10, 2015 12:21
@andrerom
Copy link
Contributor Author

Thanks @wouterj and @OskarStark, updated.

@andrerom andrerom force-pushed the bundle_dependencies branch 3 times, most recently from f01806a to fad2060 Compare August 10, 2015 12:59
@wouterj
Copy link
Member

wouterj commented Aug 10, 2015

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

links should be at the bottom of the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 2968dc2

@andrerom andrerom force-pushed the bundle_dependencies branch from fad2060 to 2968dc2 Compare August 10, 2015 14:11
@fabpot
Copy link
Member

fabpot commented Feb 14, 2016

Closing as the related PR has just been closed.

@fabpot fabpot closed this Feb 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants