Skip to content

Conversation

weaverryan
Copy link
Member

Q A
Doc fix? no
New docs? no
Applies to all
Fixed tickets #2756

Hi guys!

I wanted to close #2756, and when I started looking into things, there were a bunch of changes I wanted to make for readability. I think it's good, but of course, errors are likely :).

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really worth adding this section as the main (and first) paragraph? FOSUserBundle is great, but not for some more complex things. And to get to know things, it might be even better to actually create a User Provider.

Adding this in a tip seems better (as we do with other bundles as well).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And by the way, the reference URL needs to be added.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the note. Without it, for true beginners that don't know about FOSUserBundle, I feel like we'd be teaching them how to build a car from scratch before telling them that finished cars are available for purchase :). But, I will modify this note to mention the why/why-nots of using FOSUserBundle versus this approach

@weaverryan
Copy link
Member Author

Thanks everyone!

@weaverryan weaverryan merged commit 0bb82c6 into 2.3 Mar 23, 2015
weaverryan added a commit that referenced this pull request Mar 23, 2015
…ty (weaverryan) This PR was merged into the 2.3 branch. Discussion ---------- Proofreading and updating entity_provider for readability | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | all | Fixed tickets | #2756 Hi guys! I wanted to close #2756, and when I started looking into things, there were a bunch of changes I wanted to make for readability. I think it's good, but of course, errors are likely :). Thanks! Commits ------- 0bb82c6 Fixing bad link name 7153f3b Many fixes thanks to stof, WouterJ, xabbuh and dupuchba 768f7cc Proofreading and updating entity_provider for readability
@xabbuh xabbuh deleted the entity_provider branch March 23, 2015 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants