Skip to content

Conversation

@wouterj
Copy link
Member

@wouterj wouterj commented Dec 14, 2013

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets #3059
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for instead of form

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comma after article i think

@wouterj
Copy link
Member Author

wouterj commented Dec 15, 2013

thank you guys, fixed them all!

I don't have any clue why @zczapran's commits are included in this PR, everything is completely up to date...

@ggam
Copy link

ggam commented Dec 15, 2013

Did you add the new article to the cookbook list?

@xabbuh
Copy link
Member

xabbuh commented Dec 15, 2013

@wouterj did you branch off the 2.2 branch or did you rebase on it?

@xabbuh
Copy link
Member

xabbuh commented Dec 15, 2013

@ggam is right. You need to add the article to /cookbook/map.rst and /cookbook/security/index.rst.

@wouterj
Copy link
Member Author

wouterj commented Dec 15, 2013

@xabbuh I rebased it on origin/2.3

@xabbuh
Copy link
Member

xabbuh commented Dec 15, 2013

weird

weaverryan added a commit that referenced this pull request Dec 26, 2013
Documented CSRF protection in login forms
@weaverryan weaverryan merged commit c03f7e9 into symfony:2.3 Dec 26, 2013
@weaverryan
Copy link
Member

Thanks Wouter! Very nice job with this - complete, but straight to the point :).

Cheers!

@wouterj wouterj deleted the issue_3059 branch December 26, 2013 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants