Skip to content

Conversation

@cordoval
Copy link
Contributor

@cordoval cordoval commented Dec 6, 2013

Q A
Doc fix? yes
New docs? no
Applies to? no
Fixed tickets no
@wouterj
Copy link
Member

wouterj commented Dec 6, 2013

please use doc PR template

@cordoval
Copy link
Contributor Author

cordoval commented Dec 6, 2013

please could you have it on the documentation? is very annoying to do this not having a proper tamplate

@cordoval
Copy link
Contributor Author

cordoval commented Dec 6, 2013

@wouterj i just saw a ton of PRs, none of them had the template, yet i am guilty :rage3: he he
It is ok, i think is best to enforce this on everyone

Updated sir, yes sir.

@wouterj
Copy link
Member

wouterj commented Dec 6, 2013

Well, we don't want to have too many requirements for starters. The docs are a good place to start contributing, as we are loosy in almost everything and want to help you learning the tools required.

For small typos, having the template just scraries off people. So, we don't enforce, only the more big PRs use it.

And also, we don't have any tools which require the template, something you have on the core.

@weaverryan
Copy link
Member

Hey Luis!

Nice fix man - I've patched it into the 2.3 branch at sha: 12cd62e

Thanks!

@weaverryan weaverryan closed this Dec 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants