Skip to content

[WIP] create voters_data_permission.rst article #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

[WIP] create voters_data_permission.rst article #3138

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e14eee5
create voters_data_permission.rst article
Oct 31, 2013
f1217d7
a couple of changes according to the comments, not finished now
Oct 31, 2013
b1923b7
improvements according to the reviews
Nov 5, 2013
b72bd67
updated page with suggestion from the review
Nov 12, 2013
ed86973
Merge branch 'master' of https://github.com/symfony/symfony-docs into…
Nov 12, 2013
6817c53
improved tip box with additional link to /cookbook/security
Nov 12, 2013
a528e05
updated docs according to the reviews
Nov 26, 2013
d56730d
updated with missing fixes
Nov 26, 2013
f6db8c8
updated docs according to the review
Jan 22, 2014
3957b3a
pulled latest version from master
Jan 22, 2014
76a9db0
updated the link from ACL to the data permission voters
Jan 22, 2014
54b9877
added newline to the end of file
Jan 22, 2014
c410082
Update voter_interface.rst.inc
Jan 22, 2014
0159097
updated the docs according to the last review
Jan 22, 2014
639b188
missed one comment
Jan 22, 2014
aa8f2cc
updated according to the review
Feb 18, 2014
8540498
simplified the example
Feb 19, 2014
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improved tip box with additional link to /cookbook/security
  • Loading branch information
Michael Klein committed Nov 12, 2013
commit 6817c5390de32e9f1055c35d2476d07e2e4b7c82
6 changes: 4 additions & 2 deletions cookbook/security/voters_data_permission.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ application: :doc:`"/cookbook/security/voters"`.

.. tip::

Have a look at the referenced page if you are not familiar with
:doc:`authorization </components/security/authorization>`.
Have a look at the pages
:doc:`security </cookbook/security>` and
:doc:`authorization </components/security/authorization>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move chapter behind the doc ref:

.. tip:: Have a look at the :doc:`authorization </components/security/authorization>` chapter for a better understanding on voters.
if you are not familiar with these topics.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I like this tip. I think all cookbook articles require knowledge of the topic they are talking about.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then should we maybe stick to the single reference /components/security/authorization only? In my opinion its quiet a useful reference for a deeper understanding.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's do that.

How Symfony uses Voters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How Symfony Uses Voters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @weaverryan suggested not to capitalise verbs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a standard in the documentation now
-----------------------
Expand Down