[2.2] add explicit profiler enabling, necessary on 2.2 #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
weaverryan added a commit that referenced this pull request Mar 15, 2013
[2.2] add explicit profiler enabling, necessary on 2.2
| Very nice catch and addition Ricard - thanks! |
| This should be merged into master as well, shouldn't it? |
| @ricardclau that is done once in week by ryan, you don't need to create another PR. |
| Oh I was not aware about this workflow, thanks for clarifying 👍 |
| @ricardclau it is the same workflow than for the code :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In Symfony 2.2 you have to explicitly enable profiler in functional testing to inspect collected data.
This is covered in http://symfony.com/doc/current/cookbook/testing/profiling.html but I thought it would be better to have it documented also in this cookbook