[2.2] Updated most routing changes #2165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
components/routing/introduction.rst Outdated
| I've just created the PR for the hostname rename (see symfony/symfony#6825). |
fabpot added a commit to symfony/symfony that referenced this pull request Jan 21, 2013
This PR was merged into the master branch. Commits ------- 94f6116 renamed hostname to host in the routing system (closes #6775) 001734a [Validator] fixed phpdoc 18b9e68 [HttpFoundation] renamed hostname to host in the test to be consistent Discussion ---------- Hostname rename to host | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no (does not exist in 2.1) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6775 | License | MIT | Doc PR | symfony/symfony-docs#2165 see #6775 --------------------------------------------------------------------------- by WouterJ at 2013-01-21T18:44:20Z +1
| @weaverryan it is ready for merging! |
weaverryan added a commit that referenced this pull request Jan 22, 2013
[2.2] Updated most routing changes
weaverryan added a commit that referenced this pull request Jan 22, 2013
| Hi @wouterj! This is absolutely wonderful - thanks for your very complete work on this! I found just a few more small references that I've updated. Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Routing component has renamed some important options. This PR is fixes the most occurences of wrong Routing options in the documentation, I can't promise that every occurence is now fixed.
I marked this as a WIP because the
hostnameoption is likely to be renamed tohost, when that PR is created + merged I will change them and this PR can get merged.