[Scheduler] Add warning about comma-separated weekdays in PeriodicalTrigger #21212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wazum force-pushed the add-scheduler-comma-warning branch from 7cc7412 to 47eed9d Compare wazum force-pushed the add-scheduler-comma-warning branch from 47eed9d to c974e6d Compare 
carsonbot changed the title 
OskarStark changed the title PeriodicalTrigger 
OskarStark reviewed Jul 17, 2025
scheduler.rst Outdated
| RecurringMessage::every('3 weeks', new Message()); | ||
| RecurringMessage::every('first Monday of next month', new Message()); | ||
| | ||
| .. warning:: |
There was a problem hiding this comment.
Suggested change
| .. warning:: | |
| .. note:: |
OskarStark reviewed Jul 17, 2025
scheduler.rst Outdated
Comment on lines 300 to 301
| // With timezone (equivalent to the every() method with DateTimeImmutable): | ||
| RecurringMessage::cron('5 12 * * 1,4,6', new Message(), 'Europe/Warsaw'); |
There was a problem hiding this comment.
Suggested change
| // With timezone (equivalent to the every() method with DateTimeImmutable): | |
| RecurringMessage::cron('5 12 * * 1,4,6', new Message(), 'Europe/Warsaw'); |
OskarStark reviewed Jul 17, 2025
scheduler.rst Outdated
Comment on lines 293 to 298
| | ||
| // Instead of this (not supported): | ||
| RecurringMessage::every('Monday, Thursday, Saturday', new Message()); | ||
| | ||
| // Use this: | ||
| RecurringMessage::cron('5 12 * * 1,4,6', new Message()); |
There was a problem hiding this comment.
Suggested change
| // Instead of this (not supported): | |
| RecurringMessage::every('Monday, Thursday, Saturday', new Message()); | |
| // Use this: | |
| RecurringMessage::cron('5 12 * * 1,4,6', new Message()); | |
| .. code-block:: diff | |
| - RecurringMessage::every('Monday, Thursday, Saturday', new Message()); | |
| + RecurringMessage::cron('5 12 * * 1,4,6', new Message()); |
…PeriodicalTrigger
wazum force-pushed the add-scheduler-comma-warning branch from c974e6d to 6a007d4 Compare 
| Thanks Wolfgang ... and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue
symfony/symfony#60745
Users attempt to use comma-separated weekdays like "Monday, Thursday, Saturday" with RecurringMessage::every(), which causes silent failures due to PHP's DateInterval::createFromDateString()
Solution
Added a caution note in the PeriodicalTrigger section warning users about this limitation and providing the correct alternative using cron expressions.
Changes