[DependencyInjection] Document the different types of service arguments #21048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
OskarStark reviewed Jun 4, 2025
service_container.rst Outdated
| - !php/const true | ||
| - !php/const E_ALL | ||
| - !php/const PDO::FETCH_NUM | ||
| - !php/const App\Service\AnotherService::SOME_CONSTANT |
There was a problem hiding this comment.
To avoid this error, can we use a real constant from the codebase? 😄
There was a problem hiding this comment.
I added it to the DOCtor-RST allow list
There was a problem hiding this comment.
This will not work, the error comes from the code-blocks checker
OskarStark reviewed Jun 4, 2025
| I made some changes but this is still failing. Not sure what to do here. Can we skip the code block CI for some files? |
alamirault approved these changes Jul 18, 2025
javiereguiluz force-pushed the service_arguments branch from 7820d08 to 642c4f2 Compare | Let's merge this and see if the DOCtor-RST issue persists. Thanks. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is needed so we can configure #20167 later.