[Validator] Add Week constraint #20110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
xabbuh reviewed Aug 13, 2024
xabbuh reviewed Aug 13, 2024
xabbuh reviewed Aug 13, 2024
xabbuh reviewed Aug 13, 2024
alexandre-daubois force-pushed the week-constraint branch from 9d8c81b to a1f7838 Compare 
| Silly copy-paste from me, sorry 🤦 I addressed your comments |
xabbuh approved these changes Aug 13, 2024
alexandre-daubois force-pushed the week-constraint branch from a1f7838 to c68e60b Compare 
94noni approved these changes Aug 13, 2024
reference/constraints/Week.rst Outdated
| The ``Week`` constraint was introduced in Symfony 7.2. | ||
| | ||
| Validates that a string (or an object implementing the ``Stringable`` PHP interface) | ||
| matches a given week number. The week number format is defined by ISO-8601 |
There was a problem hiding this comment.
what about link to wikipedia ?
reference/constraints/Week.rst Outdated
| | ||
| use Symfony\Component\Validator\Constraints as Assert; | ||
| | ||
| class OnlineCourseDTO |
There was a problem hiding this comment.
entity and dto seems weird
what about removing dto ?
alexandre-daubois force-pushed the week-constraint branch from c68e60b to 148c184 Compare 
alexandre-daubois force-pushed the week-constraint branch from 148c184 to 323391d Compare 
| Alex, thanks a lot for contributing this nice constraint and the docs for it. Thanks to reviewers too. The contents were great but I made some minor tweaks while merging (3f0fdba). Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #20109