Skip to content

[Logger] Update ElasticsearchLogstashHandler documentation #19417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

[Logger] Update ElasticsearchLogstashHandler documentation #19417

merged 1 commit into from
Jan 18, 2024

Conversation

alamirault
Copy link
Contributor

Try fix #19412

  1. Add link to Monolog source code for FingersCrossedHandler and BufferHandler
  2. Add an example for production recommendation (Not tested but inspired by https://symfony.com/doc/current/logging.html#handlers-that-modify-log-entries example)
@carsonbot carsonbot added this to the 5.4 milestone Jan 14, 2024
@carsonbot carsonbot changed the title Update ElasticsearchLogstashHandler documentation [Logger] Update ElasticsearchLogstashHandler documentation Jan 18, 2024
@javiereguiluz
Copy link
Member

I'm not an expert in this, but your changes look correct to me. Let's merge this. Thanks Antoine!
@javiereguiluz javiereguiluz merged commit 1f1d6a4 into symfony:5.4 Jan 18, 2024
@alexislefebvre
Copy link
Contributor

Thanks!
@alamirault alamirault deleted the feature/19412-handler-description branch January 18, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Logger Status: Reviewed

4 participants

@alamirault @javiereguiluz @alexislefebvre @carsonbot