Skip to content

Conversation

@brikou
Copy link
Contributor

@brikou brikou commented Mar 29, 2011

I've kept Sensio it references to Sensio Framework Bundle

book/bundles.rst Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to indent it the same way than the column heading (or reduce the column width in the heading ^^)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All shared bundles I saw (including Sensio ones) use underscores to separate the different namespace part (as for the DI alias), not dots. So it would be acme_social_blog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof ok I'll check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look when this PR will be accepted because I'm not confortable with these stuffs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof Where have you seen examples of that? I'm actually seeing a bit of neither (looking in FrameworkExtraBundle) - parameters just seem the be lightly categorized, using a period as a separator (e.g. "view.template_annotation.class).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

periods are used as separator of the different parts of the parameter name. But the bundle name represent only the first segment, not one segment for each namespace. Look at all FOS bundles, SensioCasBundle, all Liip bundles, johannes's SecurityExtraBundle ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FrameworkExtraBundle does not follow this best practice at all as it does not prefix the parameters with the bundle name

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I've updated the docs to match what those well-known bundles are doing.

@weaverryan
Copy link
Member

Hey, thanks for the quick work, but I had already made this change locally before I saw this pull request. Can you let me know if I've missed anything? 808956d

Thanks!

@weaverryan weaverryan closed this Mar 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants