Skip to content

Conversation

@lsmith77
Copy link
Contributor

Mainly all the stuff mentioned in http://trac.symfony-project.org/wiki/IRCLogs20110324 plus some other minor fixes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getNamespace is required in order to support an XML confg file, even without XSD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate here? Are you talking about app or Bundle xml configs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about app config. A bundle config file will never use the semantic config namespace but only the core namespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok .. fixed that .. and submitted a PR to add a default getNamespace() implementation:
symfony/symfony#425

@lsmith77
Copy link
Contributor Author

One thing to note: I am not sure the extension stuff should be in the cookbook. To me its a pretty fundamental part of Symfony2. Aside from this, if it doest stay in the cookbook, then my note about not BC guarantee's when overriding parameters/services handled by Extensions should get a prominent place in the main docs some where.

@weaverryan weaverryan merged commit 893c225 into symfony:master Mar 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants