Skip to content

[HtmlSanitizer] Fix API usage on PHP config files #18029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2023
Merged

[HtmlSanitizer] Fix API usage on PHP config files #18029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 10 additions & 22 deletions html_sanitizer.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,16 +364,13 @@ attributes from the `W3C Standard Proposal`_ are allowed.
$framework->htmlSanitizer()
->sanitizer('app.post_sanitizer')
// allow the <article> element and 2 attributes
->allowElement('article')
->attribute('class')
->attribute('data-attr')
->allowElement('article', ['class', 'data-attr'])

// allow the <img> element and preserve the src attribute
->allowElement('img')
->attribute('src')
->allowElement('img', 'src')

// allow the <h1> element with all safe attributes
->allowElement('h1', '*')
->allowElement('h1')
;
};

Expand Down Expand Up @@ -528,12 +525,10 @@ on all elements allowed *before this setting*.
$framework->htmlSanitizer()
->sanitizer('app.post_sanitizer')
// allow "src' on <iframe> elements
->allowAttribute('src')
->element('iframe')
->allowAttribute('src', ['iframe'])

// allow "data-attr" on all elements currently allowed
->allowAttribute('data-attr')
->element('*')
->allowAttribute('data-attr', '*')
;
};

Expand Down Expand Up @@ -620,12 +615,10 @@ This option allows you to disallow attributes that were allowed before.
->element('*')

// ...except for the <section> element
->dropAttriute('data-attr')
->element('section')
->dropAttribute('data-attr', ['section'])

// disallows "style' on any allowed element
->dropAttribute('style')
->element('*')
;
};

Expand All @@ -640,7 +633,7 @@ This option allows you to disallow attributes that were allowed before.
->allowAttribute('data-attr')

// ...except for the <section> element
->dropAttriute('data-attr', ['section'])
->dropAttribute('data-attr', ['section'])

// disallows "style' on any allowed element
->dropAttribute('style')
Expand Down Expand Up @@ -695,8 +688,7 @@ element (even if the original one didn't contain a ``rel`` attribute):
return static function (FrameworkConfig $framework) {
$framework->htmlSanitizer()
->sanitizer('app.post_sanitizer')
->forceAttribute('a')
->attribute('rel', 'noopener noreferrer')
->forceAttribute('a', 'rel', 'noopener noreferrer')
;
};

Expand Down Expand Up @@ -791,9 +783,7 @@ URLs of ``<a>`` elements:

// specifies the allowed URL schemes. If the URL has a different scheme, the
// attribute will be dropped
->allowedLinkScheme('http')
->allowedLinkScheme('https')
->allowedLinkScheme('mailto')
->allowedLinkSchemes(['http', 'https', 'mailto'])

// specifies the allowed hosts, the attribute will be dropped if the
// URL contains a different host
Expand Down Expand Up @@ -907,9 +897,7 @@ the HTML sanitizer: ``src``, ``href``, ``lowsrc``, ``background`` and ``ping``.

// specifies the allowed URL schemes. If the URL has a different scheme, the
// attribute will be dropped
->allowedMediaScheme('http')
->allowedMediaScheme('https')
->allowedMediaScheme('mailto')
->allowedMediaSchemes(['http', 'https', 'mailto'])

// specifies the allowed hosts, the attribute will be dropped if the URL
// contains a different host
Expand Down