Replace Assert annotations with attributes, remove Assert annotation configuration block #17196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mdoutreluingne approved these changes Aug 21, 2022
xabbuh reviewed Aug 22, 2022
…configuration block
ker0x force-pushed the feature/assert-attributes branch from f98f54b to eed27a0 Compare 
wouterj approved these changes Aug 23, 2022
| .. configuration-block:: | ||
| | ||
| .. code-block:: php-annotations | ||
| .. code-block:: php-attributes |
There was a problem hiding this comment.
Ideally, we should backport the addition of this code block to 5.4
| Wow, thanks for all your efforts on this annotation/attribute topic Romain! |
wouterj added a commit that referenced this pull request Aug 23, 2022
This PR was merged into the 5.4 branch. Discussion ---------- add missing attributes code block see #17196 (comment) Commits ------- 5dbab03 add missing attributes code block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Following #17155, this one replace all Assert annotations!