fixed wrong namespace of UserPassword assert #1695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The Bridge/Security directory does not exist and UserPassword is part of the Security Component not the Validator component.
| @weaverryan I guess I need to reopen this on the 2.1 branch? |
| @sstok no, @weaverryan can merge this single commit PR to the 2.1 branch (and then to the master branch) himself. If your PR had more commits it would be easier. |
| " If your PR had more commits it would be easier." |
| @sstok sorry, I don't know why I stopped there... I mean 'If your PR had more commits, it would be easier if you had created a new PR.' |
weaverryan added a commit that referenced this pull request Sep 14, 2012
| Hi Sebastiaan! Yes, great find and fix! I've patched this into the 2.1 branch at sha: 19bb0d8. So yes, the PR would be better against 2.1, but it's no problem to patch it :). Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Bridge/Security directory does not exist and UserPassword is part of the Security Component not the Validator component.