[Security] Update firewall_restriction.rst #16555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hello, Can anyone take a look at this PR please ? |
carsonbot changed the title 
the correction assumes the the custom request matcher is App\Security\CustomRequestMatcher. the `request_matcher` option is the service id. it should be mentionned before that the `app.firewall.secured_area.request_matcher` is the service ID / or an alias like the following : ``` app.firewall.secured_area.request_matcher: alias: App\Security\RequestMatcher ```
| @issamkhadiri1989 sorry it took us so long to merge this. While merging we changed the branch to 5.4 and did the same changes in the XML and PHP config: 2a14cfd |
| Hello @javiereguiluz No worries :) . Thank you very much for the merge. We rock ! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
hello,
i may suggest this correction:
the correction assumes the the custom request matcher is App\Security\CustomRequestMatcher.
the
request_matcheroption is the service id. it should be mentionned before that theapp.firewall.secured_area.request_matcheris the service ID / or an alias like the following :