Cookbook adding after filter using kernel.response listener (issue #649)

[ricardclau]

This is the second part on the cookbook about setting before and after filters using Symfony2 Event Listeners. Sorry for the BIG delay about it, but as they say better later than never :)

Any typos and errors detected will be more than welcome!

Best regards

[wouterj]

Isn't it better to place this in a inline code block?

[ricardclau]

I'm sorry I don't understand what you mean here

[wouterj]

@ricardclau I mean something like this:

Before and after filters with ``kernel.controller``/``kernel.response`` events 

[ricardclau]

Oh, sure, sorry :)

[stof]

Your example is a bad one IMO. If you use a custom response class, you can do this without using a listener (simply overwrite setContent)

[ricardclau]

@wouterj I have 2 doubts regarding your catchs, comments added after yours

@stof Note that I am using the token in the request as a salt for the sha1. I don't think this can be cleanly done overwriting setContent. Moreover, the idea of using the Listener is not just for a simple hash, it is to make people aware that another "hashing service" could be injected and do some more complicated stuff after creating and returning the Response in the controller.

Anyway, if there are more -1 I can revert this, but I still think it is not a bad example. Any opinions?

[stof]

@ricardclau then I would use an example which does not use a custom Response class, as I'm quite sure some people will think that this pattern is not usable without doing it too.

[ricardclau]

@stof I am using a custom Reponse class as a way to "tag" it, so that changing the response only gets executed in that type of responses and not all of them (actually analog to the before filter example). The pattern is usable without extending Response but it would get executed for all Responses and you don't want that most of the times I guess.

Anyway, I am open to change any thing you want to make the example more useful, so I am open to suggestions!

[weaverryan]

Hi guys!

I really like this entry - takes a fairly non-technical question of how to have before/after filters and gives it a technical answer. I did make one change where I separated the before and after filters into 2 different sections to be clear about how each piece works independently. I also changed how we flagged a request to be hashed by using the request's attributes bag instead of the custom Response. Again, this was just to try to "minimize" things as much as possible so that the true important parts of the entry standout.

If anyone has any thoughts, fixes or complaints with this final version, please let me know!

Thanks Ricard for finishing up this entry!