Skip to content

Conversation

@markchalloner
Copy link

Hi,

I created a cookbook for adding custom extensions and mime types based on the _format route parameter.

@weaverryan
Copy link
Member

This is great - sorry for the delay, I'll work to merge this in shortly. There are a few things that need tweaking, but looks pretty minor.

Thanks

@markchalloner
Copy link
Author

No problem, please let me know what you want me to update.

@stof
Copy link
Member

stof commented Mar 18, 2011

The listener should be updated to the new format before merging

@weaverryan
Copy link
Member

Yep, stof is correct now, unfortunately. The new event system has just been merged in: https://github.com/symfony/symfony/tree/master/src/Symfony/Component/EventDispatcher

If you can update your PR with those changes, that would be great. I'll be working this weekend to update things for the event dispatcher anyways, so if you don't get to it, I'll make the changes.

Thanks!

@weaverryan
Copy link
Member

FYI - I'm working on this currently - should have something fairly shortly.

@weaverryan weaverryan merged commit d4151d0 into symfony:master Mar 20, 2011
@weaverryan
Copy link
Member

Merged - I reworked some of the explanations and moved the chapter, but this was very well-put together - thanks for the contribution!

@markchalloner
Copy link
Author

Pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants