[HttpClient] HttpClientInterface::setResponseFactory method #15883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
OskarStark requested changes Oct 1, 2021
http_client.rst Outdated
| | ||
| .. versionadded:: 5.4 | ||
| | ||
| The setResponseFactory() method was introduced in Symfony 5.4. |
There was a problem hiding this comment.
Method in double backticks please
OskarStark added Waiting Code Merge 
greeflas force-pushed the add_info_about_setter_method branch from 4d0b8bb to 26d763e Compare nicolas-grekas added a commit to symfony/symfony that referenced this pull request Oct 5, 2021
…k client (greeflas) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [HttpClient] Add method to set response factory in mock client | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #40620 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#15883 <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry --> Commits ------- 2e028cc [HttpClient] Add method to set response factory in mock client
wouterj force-pushed the add_info_about_setter_method branch from 26d763e to 76bd5fb Compare 
| Thank you @greeflas! The feature looks great, and you're my hero for also documenting features you add to Symfony core :) I've moved your example a bit further up, but other than that the PR is perfect! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.