[DependencyInjection] add tagged argument locator #15821
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Sep 17, 2021
…as service locator arguments (IonBazan) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Allow injecting tagged iterator as service locator arguments | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#15821 Not sure if this is a feature or bug fix - kindly update the description and target branch and I will backport the changes for older version if needed. This feature allows creating a named (reusable) service locator using tagged services: ```yml services: _instanceof: App\Command\HandlerInterface: tags: ['app.command_handler'] app.command_handlers: class: Symfony\Component\DependencyInjection\ServiceLocator arguments: [!tagged_iterator { tag: 'app.command_handler', default_index_method: 'getCommandName' }] App\CommandBus: arguments: ['`@app`.command_handlers'] App\AnotherCommandBus: arguments: ['`@app`.command_handlers'] ``` Prior to this change, following error would be thrown: ``` Invalid definition for service "app.command_handlers": an array of references is expected as first argument when the "container.service_locator" tag is set. ``` Commits ------- 7c86ac8 Allow injecting tagged iterator as service locator arguments
| Thank you @IonBazan for your contribution! We're closing this PR due to lack of recent activity. If this documentation is still needed, please feel free to open a new PR against the current version of the docs. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Documents symfony/symfony#43015
This is my first docs contribution so please let me know if it's correct.