Update login_link.rst #14700
Merged
Update login_link.rst #14700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ghost reviewed Dec 15, 2020
OskarStark reviewed Dec 16, 2020
OskarStark reviewed Dec 16, 2020
OskarStark reviewed Dec 16, 2020
OskarStark reviewed Dec 16, 2020
OskarStark reviewed Dec 16, 2020
OskarStark approved these changes Dec 17, 2020
OskarStark reviewed Dec 17, 2020
OskarStark approved these changes Dec 17, 2020
| @OskarStark Is it still relevant? |
| @wouterj can you please review this PR? Thanks |
| Thank you @ulinskas! I've slightly reworded this section in 8680b94 , but other than that this is perfect :) I'm a bit interested with the example though: if I'm correct, this URL is clicked on by the user (i.e. it's opened in a browser), in which situation does it make sense to return a JSON response in that case? |
| @wouterj |
wouterj added a commit that referenced this pull request Apr 8, 2021
* 5.2: Add troubleshooting for parallel merges to maintainer guide Update framework.rst JsonResponse content updated Fixed table markup [Messenger] Add options for PostgreSQL LISTEN/NOTIFY support Update data_collector.rst [#14728] Be explicit about the double 's' [#14700] Minor rewording Update login_link.rst Added explaination on context in events and initial marking [Messenger] fix typo [Messenger] Routing & Inheritance docs(http-client): fix default retry_failed configuration example [Cache] Add TLS scheme for Redis connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added extra information how to use success handler