book/page_creation.html#environments fixed typo Line 730, replaced semi-colon with colon in URL address #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
was: http;//localhost/app.php/hello/Ryan now: http://localhost/app.php/hello/Ryan
Member
| You should create a topic branch. Everything is explained here: http://symfony.com/doc/2.0/contributing/code/patches.html Anyway, your change has been merged. Thanks. |
Contributor Author
| Ah thank you for the link to patches. I was only focused on documentation so I went to that section of the Contribution, and did not know about the topic branch. Guess what my next Git patch will be :) |
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
http://symfony.com/doc/2.0/book/page_creation.html#environments
730 - http;//localhost/app.php/hello/Ryan
730 + http://localhost/app.php/hello/Ryan
(I am a virgin Git user, this is my first attempt to contribute. did I do this correctly?
forked
clone
edit
commit
push
pull request
)