[RateLimiter] Add diagrams to better explain the differences #14436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wouterj force-pushed the ratelimiter/add-diagrams branch from 327dee2 to 9843b28 Compare 
| I like them a lot! Good work!! |
wouterj force-pushed the ratelimiter/add-diagrams branch from 9843b28 to cdf3b76 Compare 
| IMO this should now target |
| These still look very nice to me. Wouter, do you plan to add some polish or do you think we can merge this? Thanks! |
wouterj force-pushed the ratelimiter/add-diagrams branch from cdf3b76 to 32df98d Compare 
| Sorry, I forgot about this one. I'm not 100% happy with the text (it seems a bit too verbose to me), but this should be ready for a review & merge. |
javiereguiluz force-pushed the ratelimiter/add-diagrams branch from 32df98d to 1cdb6cb Compare | Merged in 5.2 and up. Thanks Wouter! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is just a POC to add some diagrams to better explain the differences in the rate limiter strategies.