[DependencyInjection] Document the Required attribute #14394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
derrabus changed the title 
wouterj approved these changes Oct 12, 2020
derrabus commented Oct 13, 2020
derrabus commented Oct 13, 2020
derrabus force-pushed the feature/required-attribute branch from c3230d7 to 701f704 Compare 
| Rebased. Let's see if @Nyholm's changes fix the build. 😃 |
| The build is green. 🎉 |
| I can’t believe you doubted me. :) |
| Thanks Alexander! I'm so excited about PHP 8 attributes, that I love all the contributions you are making to introduce them in Symfony. Thanks a lot! |
| Thank you, @javiereguiluz! If you want to see the attributes in action, have a look at symfony/demo#1169. 😃 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for symfony/symfony#37545 and fixes #14189.