[Security] Added login link documentation #14389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wouterj commented Oct 11, 2020
wouterj force-pushed the issue-14324/login-link-auth branch from b4fa831 to f9f3720 Compare 
| Login links, also called "magic links", allow users to login without | ||
| passwords. Whenever a user wants to login, a login link is generated and | ||
| send to the user (e.g. using an e-mail). The user is logged in as soon as | ||
| they visit that link. |
Contributor
There was a problem hiding this comment.
The user and they feel weird
Why not write : as soon as the link is visited
Member
javiereguiluz left a comment
javiereguiluz left a comment There was a problem hiding this comment.
Very nice contribution!
weaverryan reviewed Oct 12, 2020
fabpot added a commit to symfony/symfony that referenced this pull request Oct 13, 2020
…henticator (wouterj) This PR was squashed before being merged into the 5.x branch. Discussion ---------- [Security] Added check_post_only to the login link authenticator | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This is useful when adding a page that requires a user action in order to validate the check link. That is required when using a single-use login link, to workaround browser and email client previews (which trigger a request). See also the short docs discussion about this: symfony/symfony-docs#14389 (comment) For reference, I choose this option name as it relates to the `post_only` option in the `FormLoginAuthenticator`, which is about exactly the same thing. I didn't think `post_only` was a 100% clear name, but I'm happy to change this option to that for complete consistency. cc @weaverryan Commits ------- 5093e0d [Security] Added check_post_only to the login link authenticator
wouterj force-pushed the issue-14324/login-link-auth branch from f9f3720 to bc257ee Compare 
Member Author
| Thanks for the reviews! I've updated the PR, taking into account the 2 PRs that were merged after creating this PR and the 1 PR that isn't yet merged: symfony/symfony#38552 So please do not merge this yet. |
Member Author
| The related PR has been merged, ready to merge imho |
wouterj force-pushed the issue-14324/login-link-auth branch from bc257ee to 8ed0916 Compare 
Member
| Wouter, thanks for this fantastic contribution! Thanks to reviewers too!! While merging I tweaked the intro a bit but the rest was left intact. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #14324, #14385