cache doctor rst #13250
Merged
cache doctor rst #13250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
smoench force-pushed the 34-cache-doctor-rst branch 2 times, most recently from e83f689 to fa2059e Compare 
OskarStark approved these changes Feb 25, 2020
smoench force-pushed the 34-cache-doctor-rst branch 3 times, most recently from 76e871a to e95cba5 Compare 
| Can |
smoench force-pushed the 34-cache-doctor-rst branch 6 times, most recently from afe06a6 to f48ff98 Compare | I had to create |
smoench commented Feb 25, 2020
smoench force-pushed the 34-cache-doctor-rst branch from f48ff98 to 34ac5ce Compare | Should I also provide PRs for 4.4, 5.0 and master? |
| @smoench no, don't worry. We merge each PR in all active merges up to |
| @javiereguiluz I was just asking as the suffix of cache key might has to change to base branch name |
OskarStark reviewed Feb 26, 2020
smoench force-pushed the 34-cache-doctor-rst branch 4 times, most recently from 46c8790 to 16df0d2 Compare smoench force-pushed the 34-cache-doctor-rst branch 4 times, most recently from 956b0d3 to 6f0dfd1 Compare OskarStark approved these changes Feb 26, 2020
smoench force-pushed the 34-cache-doctor-rst branch 2 times, most recently from f64c784 to 595501b Compare 
| Wow |
|
|
smoench force-pushed the 34-cache-doctor-rst branch from 595501b to 12f6ddc Compare | Got it work. Ready for merge |
OskarStark reviewed Feb 27, 2020
| uses: actions/cache@v1 | ||
| with: | ||
| path: .cache | ||
| key: ${{ runner.os }}-doctor-rst-${{ steps.extract_base_branch.outputs.branch }} |
OskarStark approved these changes Feb 27, 2020
| Thank you Simon. |
| From about ~10min to seconds 🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adapts the latest contribution OskarStark/doctor-rst#626