Hint for generating container preload file #12909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The container preload file will only be generated when both factories and class_loader are inline, so you need to set both parameters to `true` explicitly.
javiereguiluz added Status: Reviewed Performance and removed Status: Needs Review labels javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 12, 2020
This PR was merged into the 4.4 branch. Discussion ---------- Hint for generating container preload file The container preload file will only be generated when both factories and class_loader are inline, so you need to set both parameters to `true` explicitly. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 0e6a885 Hint for generating container preload file
| @Basster nice improvement! I wasn't aware of this. Thanks and congrats on your first Symfony Docs contribution! |
| @Basster / @javiereguiluz I'm not sure if this step is still necessary. Enabling / disabling these in my app doesn't seem to matter, the preload file is generated and performance isn't measurably different. I think maybe symfony/symfony#36193 caused this setting to no longer be necessary in 5.1? I hesitate to create a PR though because I'm not sure what these options do exactly and why they may be needed in different environments. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The container preload file will only be generated when both factories and class_loader are inline, so you need to set both parameters to
trueexplicitly.