Clarified the two main types of exceptions thrown in HttpClient #12768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Based onto 4.4 and addressed comments. I guess I don't need to rebase and force push as you're going to squash merge anyway? :) |
Toflar force-pushed the describe-http-client-exceptions branch from 41c672a to 1e13d5f Compare | Rebased :) |
Toflar force-pushed the describe-http-client-exceptions branch from 1e13d5f to d815202 Compare | Sorry, messed up with the rebase. Should be fixed now 🤦♂ |
nicolas-grekas approved these changes Feb 24, 2020
| Thanks Yanick. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As learned from @nicolas-grekas in symfony/symfony#34837.
I guess it's worth clarifying it a little bit :)