Skip to content

Conversation

@catchamonkey
Copy link
Contributor

Fixed a small grammatical error in the HTTP Fundamentals chapter

@weaverryan
Copy link
Member

Hey, can you rebase your commits (and squash into just one commit)? The change is legit, but I'd like only one commit for the change (it makes the history easier to follow).

Thanks!

@catchamonkey
Copy link
Contributor Author

Best close this one and i'll open another clean... Haven't quite mastered a rebase of that size clearly ;)

@catchamonkey
Copy link
Contributor Author

Ah there we go.
Not the cleanest way i've done it... But there we go.
Ready for merging.

@weaverryan
Copy link
Member

FYI - the way you cleaned up the PR was perfect - squash and then force push on your branch. Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants