Skip to content

Conversation

phoefnagel
Copy link
Contributor

@phoefnagel phoefnagel commented Oct 31, 2019

Noticed they were missing so I added them.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks Peter ... and congrats on your first Symfony Docs contribution!

Note to mergers: merge it in 4.3 branch. Thanks.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Oct 31, 2019
@OskarStark OskarStark changed the base branch from master to 4.3 October 31, 2019 15:05
@OskarStark
Copy link
Contributor

... and one more bug fixed, thank you Peter.

OskarStark added a commit that referenced this pull request Oct 31, 2019
…efnagel) This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #12573). Discussion ---------- Added missing closing parentheses and closing bracket Noticed they were missing so I added them. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 43a239b Missing closing parentheses and closing bracket
@OskarStark OskarStark merged commit 43a239b into symfony:4.3 Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants