Explain how to add from_transport on messenger.message_handler tag #12231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fabpot added a commit to symfony/symfony that referenced this pull request Sep 25, 2019
…te on `messenger.message_handler` tag (ruudk) This PR was squashed before being merged into the 4.4 branch (closes #33317). Discussion ---------- [Messenger] Added support for `from_transport` attribute on `messenger.message_handler` tag | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33306 | License | MIT | Doc PR | symfony/symfony-docs#12231 Right now, it's only possible to have dynamic `from_transport` when using `MessageSubscriberInterface`. Things like `priority` and `bus` can already be added as attributes on the messenger.message_handler` tag. With this PR it now also supports `from_transport`. Commits ------- c965e4e [Messenger] Added support for `from_transport` attribute on `messenger.message_handler` tag
symfony-splitter pushed a commit to symfony/messenger that referenced this pull request Sep 25, 2019
…te on `messenger.message_handler` tag (ruudk) This PR was squashed before being merged into the 4.4 branch (closes #33317). Discussion ---------- [Messenger] Added support for `from_transport` attribute on `messenger.message_handler` tag | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33306 | License | MIT | Doc PR | symfony/symfony-docs#12231 Right now, it's only possible to have dynamic `from_transport` when using `MessageSubscriberInterface`. Things like `priority` and `bus` can already be added as attributes on the messenger.message_handler` tag. With this PR it now also supports `from_transport`. Commits ------- c965e4e844 [Messenger] Added support for `from_transport` attribute on `messenger.message_handler` tag
| Anything I can do to get this PR merged? |
OskarStark requested changes Nov 2, 2019
dbrumann approved these changes Nov 5, 2019
wouterj added a commit that referenced this pull request Nov 9, 2019
…age_handler` tag (ruudk) This PR was squashed before being merged into the 4.4 branch (closes #12231). Discussion ---------- Explain how to add `from_transport` on `messenger.message_handler` tag See symfony/symfony#33317 Commits ------- 03ed48e Explain how to add `from_transport` on `messenger.message_handler` tag
wouterj added a commit that referenced this pull request Nov 9, 2019
| Hi @ruudk! Thanks for submitting a doc PR alongside your feature PR and congratz on getting it merged! I've now merged this pull requests as well. I moved the docs you added to the section explaining the tag. I think it's a bit more usefull to have it there. I've now also explicitly added a list of options that can be configured, as I couldn't find it anywhere in the docs (and it seems like the comment "options returned by getHandledMessages() are supported here" wasn't true for at least Symfony <4.4). You can see the changes in b8526c3. Please let me know if you disagree :) |
wouterj added a commit that referenced this pull request Nov 9, 2019
* 4.4: [#12231] Explicitly name the options that can be configured through tags Explain how to add `from_transport` on `messenger.message_handler` tag Documented the new REMOTE_ADDR option [#12464] Minor changes Add Composer installation before step 1 for Symfony Flex Documentation for Bootstrap 4 custom switches
symfony-splitter pushed a commit to symfony/messenger that referenced this pull request Jan 28, 2020
…te on `messenger.message_handler` tag (ruudk) This PR was squashed before being merged into the 4.4 branch (closes #33317). Discussion ---------- [Messenger] Added support for `from_transport` attribute on `messenger.message_handler` tag | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33306 | License | MIT | Doc PR | symfony/symfony-docs#12231 Right now, it's only possible to have dynamic `from_transport` when using `MessageSubscriberInterface`. Things like `priority` and `bus` can already be added as attributes on the messenger.message_handler` tag. With this PR it now also supports `from_transport`. Commits ------- c965e4e844 [Messenger] Added support for `from_transport` attribute on `messenger.message_handler` tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See symfony/symfony#33317