Skip to content

Conversation

k0d3r1s
Copy link
Contributor

@k0d3r1s k0d3r1s commented Aug 11, 2019

Documentation for symfony/symfony#33117

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment

fabpot added a commit to symfony/symfony that referenced this pull request Sep 8, 2019
…pdateCommand (k0d3r1s) This PR was squashed before being merged into the 4.4 branch (closes #33117). Discussion ---------- [FrameworkBundle] Added --sort option for TranslationUpdateCommand | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33014 | License | MIT | Doc PR | symfony/symfony-docs#12136 Added sorting option for translation:update command Commits ------- 3249a4e [FrameworkBundle] Added --sort option for TranslationUpdateCommand
@k0d3r1s k0d3r1s requested a review from OskarStark September 9, 2019 12:44
@javiereguiluz javiereguiluz removed the Waiting Code Merge Docs for features pending to be merged label Sep 18, 2019
@javiereguiluz
Copy link
Member

Dāvis, thanks for contributing this feature and for mentioning it in the docs. It's now merged!

javiereguiluz added a commit that referenced this pull request Sep 18, 2019
…ate command (k0d3r1s) This PR was squashed before being merged into the 4.4 branch (closes #12136). Discussion ---------- Added documentation for --sort option in translation:update command Documentation for symfony/symfony#33117 Commits ------- aae353a Added documentation for --sort option in translation:update command
@javiereguiluz javiereguiluz merged commit aae353a into symfony:4.4 Sep 18, 2019
javiereguiluz added a commit that referenced this pull request Sep 18, 2019
…ate command (javiereguiluz) This PR was merged into the 4.3 branch. Discussion ---------- Minor improvement for the docs about the translation:update command After merging #12136, I realized we don't explain this command well ... so let's tweak it. Commits ------- 182d927 Minor improvement for the docs about the translation:update command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment