Updated some console commands #12078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
OskarStark approved these changes Aug 2, 2019
| As you can see in https://pr-12078-jjvhw7y-nq3xa5jtywvyc.eu.s5y.io/setup.html, this worked ... but the CSS classes are modified a bit. So, let's replace the double dash by a single dash:
|
maxhelias approved these changes Aug 2, 2019
javiereguiluz force-pushed the command_tweaks branch from 7fe6c54 to bd50c9a Compare javiereguiluz added a commit that referenced this pull request Aug 2, 2019
This PR was squashed before being merged into the 3.4 branch (closes #12078). Discussion ---------- Updated some console commands This makes two changes: * I was told on Symfony Slack that using `c:\>` is wrong for Windows. Better use `>` (even if you have run a `cd ...` command before) * On symfony.com the console decoration changes depending on your operating system. But in the docs, some commands are only for Windows or only for Linux/macOS. In those special cases, we cannot change the console decoration, so let's apply a CSS class to tell that they are Windows-only or Linux-only commands. Commits ------- bd50c9a Updated some console commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This makes two changes:
c:\>is wrong for Windows. Better use>(even if you have run acd ...command before)