Improve doc for HttpClient #11586
Merged
Improve doc for HttpClient #11586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
OskarStark reviewed May 19, 2019
| First comments addressed, ready for merge if you're OK with fixing the TODOs later. |
| Just asking, is there some benchmarks comparing this httpclient with others php ones? Thank you |
| @noniagriconomie I found this recently: https://twitter.com/jderusse/status/1115333801419399170 |
| @OskarStark yes i found it to once, but i mean real benchmarks |
| Thank you Nicolas. |
javiereguiluz added a commit that referenced this pull request May 29, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Improve doc for HttpClient While in the plane from SymfonyLive Sao Paulo :) Commits ------- fb24e7b Improve doc for HttpClient
nicolas-grekas commented May 29, 2019
| directly under the ``framework.http_client`` option: | ||
| When the HttpClient component is installed, an HTTP client is available | ||
| as a service named ``http_client`` or using the autowiring alias | ||
| :class:`Symfony\\Constracts\\HttpClient\\HttpClientInterface`. |
There was a problem hiding this comment.
s/Constracts/Contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While in the plane from SymfonyLive Sao Paulo :)