[Cache] Update cache for 4.2 #11391
Closed
[Cache] Update cache for 4.2 #11391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
OskarStark reviewed Apr 10, 2019
Nyholm commented Apr 10, 2019
| Thank you for the reviews. I've updated the PR |
wouterj approved these changes Apr 10, 2019
| Tobias, thanks for taking care of finishing this doc. We've merged it in 4.2 and master. |
| Woho, Thank you =) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This will continue the work started in #10685
We need to document the CacheInterface from Contracts better.