Skip to content

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark changed the title be keen to newcomers [WIP] be keen to newcomers Feb 22, 2019
@OskarStark OskarStark force-pushed the be-keen-to-newcomers branch 3 times, most recently from cd62bb5 to ece09bc Compare February 22, 2019 13:12
@OskarStark OskarStark changed the title [WIP] be keen to newcomers be keen to newcomers Feb 22, 2019
@OskarStark
Copy link
Contributor Author

This PR is ready to review, it would grow too much

I will open another following PR if this is done.

@javiereguiluz
Copy link
Member

Thanks Oskar! I've merged this one to avoid having a too big and too difficult to merge pull request. We can merge PRs like this in the future to fix more issues.

@javiereguiluz javiereguiluz merged commit 6f30499 into symfony:3.4 Feb 22, 2019
javiereguiluz added a commit that referenced this pull request Feb 22, 2019
This PR was merged into the 3.4 branch. Discussion ---------- be keen to newcomers <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 6f30499 be keen to newcomers
@OskarStark OskarStark deleted the be-keen-to-newcomers branch February 22, 2019 15:55
fabpot added a commit to symfony/symfony that referenced this pull request Feb 22, 2019
This PR was merged into the 3.4 branch. Discussion ---------- be keen to newcomers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#11036 Commits ------- c008ee0 be keen to newcomers
javiereguiluz added a commit that referenced this pull request Feb 26, 2019
This PR was squashed before being merged into the 3.4 branch (closes #11044). Discussion ---------- be keen to newcomers Do not use **easy**, **easily** and **simply** This is a follow-up PR of #11036 Commits ------- 979274b be keen to newcomers
joshtrichards pushed a commit to joshtrichards/symfony-finder that referenced this pull request Apr 26, 2024
This PR was merged into the 3.4 branch. Discussion ---------- be keen to newcomers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#11036 Commits ------- e54b10c be keen to newcomers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants