Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jan 14, 2019

Now that symfony/symfony/pull/29811 is done we need to reflect these changes in the documentation.

@ghost ghost changed the base branch from master to 3.4 January 14, 2019 07:46
@javiereguiluz javiereguiluz added this to the 3.4 milestone Jan 14, 2019
@javiereguiluz
Copy link
Member

@ricknox when you think this is ready to merge, please tell us. Thanks!

@ghost
Copy link
Author

ghost commented Jan 14, 2019

@javiereguiluz I'm trying to finish this up tomorrow, hopefully.

Copy link
Contributor

@jmsche jmsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making docs easier to read :)

jmsche and others added 2 commits January 15, 2019 12:01
Co-Authored-By: ricknox <ricardo@43.nl>
Co-Authored-By: ricknox <ricardo@43.nl>
@ghost
Copy link
Author

ghost commented Jan 15, 2019

Thank you @jmsche for your improvements.

@javiereguiluz
Copy link
Member

I'm going to merge this now. If we find other missing changes, we can fix them later. Thanks.

@javiereguiluz
Copy link
Member

Thanks Ricardo.

@javiereguiluz javiereguiluz merged commit eac8e90 into symfony:3.4 Jan 15, 2019
javiereguiluz added a commit that referenced this pull request Jan 15, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Short array syntax Now that symfony/symfony/pull/29811 is done we need to reflect these changes in the documentation. Commits ------- eac8e90 Apply suggestions/improvements from code review. 535d3a9 Apply suggestions/improvements from code review. a4440f9 chore: (2/2) Replace long with short syntax. 96f68fe chore: (1/2) Replace long with short syntax. 10e3a9e fix: Swap long with short syntax.
@ghost ghost deleted the short-array-syntax branch January 15, 2019 16:24
@javiereguiluz
Copy link
Member

This has now been merged up to 4.1, 4.2 and master branches. I fixed a lot of array() occurrences on those branches but I may have missed some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants