[Forms] Fixed TextType empty_data value explanation #10743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
HeahDude reviewed Dec 8, 2018
| The default value is ``''`` (the empty string). | ||
| From an HTTP perspective, submitted data is always a string or an array of strings. | ||
| So by default, the form will treat any empty string as null. If you prefer to get | ||
| an empty string, explicitly set the ``empty_data`` option to an empty string. |
There was a problem hiding this comment.
@symfony/team-symfony-docs should we care about adding a note to say this possible since 3.2 only?
There was a problem hiding this comment.
Not needed because we merge in 3.4, so the minimum Symfony version already has that.
vudaltsov changed the title 
| #SymfonyConHackday2018 |
| Much better explained. Thanks a lot Valentin! |
javiereguiluz added a commit that referenced this pull request Dec 8, 2018
…altsov) This PR was merged into the 3.4 branch. Discussion ---------- [Forms] Fixed TextType empty_data value explanation #SymfonyConHackDay See symfony/symfony#18357 that introduced a way to use an empty string in models, so setter does not have to be nullable. Usage example: https://github.com/EnMarche/en-marche.fr/blob/master/src/Form/TypeExtension/TextTypeExtension.php#L28 Thanx to @HeahDude for helping me with this PR. Commits ------- 5cfff92 Fix TextType empty_data value explanation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#SymfonyConHackDay
See symfony/symfony#18357 that introduced a way to use an empty string in models, so setter does not have to be nullable. Usage example: https://github.com/EnMarche/en-marche.fr/blob/master/src/Form/TypeExtension/TextTypeExtension.php#L28
Thanx to @HeahDude for helping me with this PR.