Rename content_type header to content-type #10651
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
javiereguiluz approved these changes Nov 9, 2018
There was a problem hiding this comment.
Nice! I think we should do this.
I'm not entirely sure about adding the comment about underscored HTTP headers. @xabbuh do you think we should add it ... or better remove it to lower our readers' cognitive load? Thanks!
kunicmarko20 reviewed Nov 9, 2018
| agree, will remove it |
ottaviano force-pushed the fix-http-header-key branch from d49a33f to cea94f4 Compare kunicmarko20 approved these changes Nov 9, 2018
xabbuh approved these changes Nov 10, 2018
| Thank you @ottaviano. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.