Refactor exception handling while destructing the client. #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Bump php-webdriver/webdriver to 1.14.0, because they introduced a common interface to identify all exceptions thrown in php-webdriver.
…destruction despite WebDriver exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While testing I stumbled over #466 again with errors like:
I mentioned that the WebDriverCurlException doesn't inherit from WebDriverException and therefore wasn't caught.
While digging in the code, I'v found that php-webdriver/webdriver introduced a common exception interface in 1.14.0 (from 2023-02-09), so I though its safe/mature enough to bump the dependency version.
I also found out that if destructing of the Client fails, the BrowserManager will not quit, so I moved the exception handling for the webdriver exceptions into the actual quit method.