Revert "Updated the DocBlocks of the Entities from consistency pov" #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…of view." This reverts commit e039e60.
| Victor, thanks for taking care of this. One day we'll upgrade to PHP 7.1 and we'll use "string" and "int" as the return type hint; can you imagine that!? |
javiereguiluz added a commit that referenced this pull request Apr 21, 2017
…ency pov" (bocharsky-bw) This PR was merged into the master branch. Discussion ---------- Revert "Updated the DocBlocks of the Entities from consistency pov" This reverts #527 The reasons were described earlier in #394 Commits ------- 88d2100 Revert "Updated the DocBlocks of the Entities from consistency point of view."
| Oh man, I'm really waiting for it - it's my favorite PHP7 feature :) And then we won't need the remaining annotation for getters/setters at all! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This reverts #527
The reasons were described earlier in #394