[MCP Bundle] Fix services when monolog is not installed #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WebMamba requested review from Nyholm, OskarStark and chr-hertel as code owners 
carsonbot changed the title 
Author
| @chr-hertel tell me what you think about this solution, but while working on it I was thinking that just require monolog could be even better. I don't see any good reason to not use it. |
chr-hertel added the MCP Bundle carsonbot changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As said on the issue, when monolog is not installed, the container can't compile the services.
The solution here is to register the service only if the bundle is installed