Skip to content

Conversation

@EmmEff
Copy link
Contributor

@EmmEff EmmEff commented Feb 21, 2023

This PR unexports client attributes that do not need to be exported.

Copy link

@wobito wobito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Singularity build fails with this PR seems to use the BaseURL attribute

../internal/app/singularity/push.go:118:45: libraryClient.BaseURL undefined (type *"github.com/sylabs/scs-library-client/client".Client has no field or method BaseURL) 
@EmmEff
Copy link
Contributor Author

EmmEff commented Feb 21, 2023

Good catch! Singularity will need a patch to be able to use v2 of scs-library-client, which I will create once the first v2 release has been tagged.

@EmmEff EmmEff force-pushed the unexport-client-attributes branch from 06a0ab5 to 7a70528 Compare February 21, 2023 17:19
@codecov-commenter
Copy link

Codecov Report

Merging #167 (06a0ab5) into main (7ba7416) will increase coverage by 0.03%.
The diff coverage is 46.06%.

❗ Current head 06a0ab5 differs from pull request most recent head 7a70528. Consider uploading reports for the commit 7a70528 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@ Coverage Diff @@ ## main #167 +/- ## ========================================== + Coverage 34.59% 34.62% +0.03%  ========================================== Files 13 13 Lines 2006 2007 +1 ========================================== + Hits 694 695 +1  Misses 1235 1235 Partials 77 77 
Impacted Files Coverage Δ
client/push.go 10.87% <9.75%> (ø)
client/oci.go 5.67% <42.85%> (ø)
client/version.go 60.00% <50.00%> (ø)
client/pull.go 50.87% <66.66%> (ø)
client/api.go 60.49% <83.33%> (ø)
client/client.go 94.54% <100.00%> (+0.10%) ⬆️
client/downloader.go 75.29% <100.00%> (ø)
client/restclient.go 75.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@EmmEff EmmEff merged commit 44a15bb into sylabs:main Feb 24, 2023
@EmmEff EmmEff deleted the unexport-client-attributes branch February 24, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants