Skip to content

Resolve short named artifact issue #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2023
Merged

Resolve short named artifact issue #163

merged 3 commits into from
Feb 9, 2023

Conversation

@EmmEff
Copy link
Contributor

@EmmEff EmmEff commented Feb 9, 2023

This PR implements client-side support for OCI artifact name mapping
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023 •
edited
Loading

Codecov Report

Merging #163 (155a22b) into v1 (b5db2aa) will decrease coverage by 0.63%.
The diff coverage is 30.76%.

❗ Current head 155a22b differs from pull request most recent head 720f761. Consider uploading reports for the commit 720f761 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@ Coverage Diff @@ ## v1 #163 +/- ## ========================================== - Coverage 35.06% 34.44% -0.63%  ========================================== Files 13 13 Lines 2056 2015 -41 ========================================== - Hits 721 694 -27  + Misses 1250 1244 -6  + Partials 85 77 -8
Impacted Files Coverage Δ
client/pull.go 49.12% <0.00%> (-2.42%) ⬇️
client/oci.go 5.75% <19.04%> (+0.08%) ⬆️
client/downloader.go 75.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@EmmEff EmmEff changed the base branch from main to v1 February 9, 2023 13:14
@EmmEff EmmEff force-pushed the oci-artifact-name-mapping branch from 155a22b to 720f761 Compare February 9, 2023 13:15
dtrudg
dtrudg reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about possibility of the resolvedName being ""
dtrudg
dtrudg approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against a patched server... I see the short name pull working, and unauthenticated OCI download working.

Tested against unpatched, I see the same behavior as before. I.E. no regression.
@EmmEff EmmEff merged commit f063ec9 into sylabs:v1 Feb 9, 2023
@EmmEff EmmEff deleted the oci-artifact-name-mapping branch February 9, 2023 17:39
@edytuk edytuk mentioned this pull request Feb 15, 2023
Merged
@DrDaveD
Copy link

DrDaveD commented Feb 15, 2023

Is this also going to go into the main branch?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@EmmEff @codecov-commenter @DrDaveD @dtrudg