This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Fix incorrect SWOOLE_PROCESS value #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
m3m0r7 changed the title 
Contributor
| Thanks for your contribution! It looks right |
Arkanius approved these changes Nov 24, 2020
Member
| Hi @m3m0r7 , Thanks a lot for you pull request! |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello, I found a bug that the
SWOOLE_PROCESSvalue is incorrect.In swoole
MODE_PROCESSis2, not3.See: https://github.com/swoole/swoole-src/blob/b09a7e9acb2c19c91f2c69df449c9fa77be5d010/include/swoole_server.h#L511
and https://github.com/swoole/swoole-src/blob/b09a7e9acb2c19c91f2c69df449c9fa77be5d010/ext-src/php_swoole.cc#L426
In some cases, It will get an error when running a server with
SWOOLE_PROCESSonswoole_http.phpconfig file.It will show
Swoole\Server::__construct(): invalid $mode parameters 3See: https://github.com/swoole/swoole-src/blob/b09a7e9acb2c19c91f2c69df449c9fa77be5d010/ext-src/swoole_server.cc#L1994