This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Replace FatalThrowableError with FatalError #417
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Debug component was deprecated and replaced by ErrorHandler in Symfony 4.4. Laravel 7 uses a Symfony 5 which does not contain Debug anymore, therefore app crashes.
ErrorHandler does not have a similar class, therefore I extracted a little bit of logic from the old FatalThrowableError to construct a FatalError object.
Fixes #406
EDIT: using getCode() on exception may be a better choice, however, it would behave differently than the old class.