[SILGen]: Emit ignored loads of uninhabited lvalues to address DI edge cases #85381
+63 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @swift-ci smoke test macos |
Contributor Author
| @swift-ci please test source compatibility |
…e cases Previously we would crash on this pattern: ```swift let x: Never switch x {} ``` This appears to be due to the fact that the switch over the uninhabited value did not result in any instructions DI considers a use being produced. This change adds special handling of this case so that we now emit a load of the value so DI correctly diagnoses the use before init. Contributor Author
| @swift-ci please test |
jamieQ commented Nov 8, 2025
| // Failure to do this in the past resulted in this bug: | ||
| // https://github.com/swiftlang/swift/issues/74478. | ||
| | ||
| emitLoadOfLValue(E, std::move(lv), SGFContext::AllowImmediatePlusZero); |
Contributor Author
There was a problem hiding this comment.
could someone verify if it matters what SGFContext value is used here? i assume this case should always result in a downstream error so i'm inclined to think it doesn't...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously we would crash (at runtime) on this pattern:
This appears to be due to the fact that the switch over the uninhabited value did not result in any instructions DI considers a use being produced. This change adds special handling of this case so that we now emit a load of the value so DI correctly diagnoses the use before init.
Resolves: #74478